infra(unicorn): prevent-abbreviations #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
p: 1-normal
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ST-DDT
changed the title
|
The PR title was somehow cached from the last PR... |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3320 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2811 2811
Lines 217012 217012
Branches 939 939
=======================================
Hits 216959 216959
Misses 53 53 |
xDivisionByZerox
approved these changes
Dec 16, 2024
ejcheng
approved these changes
Dec 21, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #2439 (last rule)
Permanently disables the
unicorn/prevent-abbreviationslint rule.This rule prevents the usage of abbreviations such as i => index, doc => document/documentation and many more.
IMO these are mostly irrelevant changes and barely/don't contribute to the readability of the code, so I would like to disable this rule, especially since it increases the barrier of entry to the repository.
I tackled a few slightly more valid cases in separate PRs:
For the remaining changes I pushed a commit just as a reference/lookup for the other ~200 renames (reduced by a few ignores).
Feel free to look at the PR whether there is still something valid in there.