Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(locale): add german animal types #3334

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat(locale): add german animal types #3334

merged 1 commit into from
Dec 13, 2024

Conversation

motz0815
Copy link
Contributor

This PR just adds German animal types. They are the same animals as in the en locale, just translated to German. (Confirmed by me, German native speaker)

I also sorted the definitions in alphabetical order (respecting "Umlaute" i.e. äöü being at the back)

@motz0815 motz0815 requested a review from a team as a code owner December 12, 2024 19:38
Copy link

netlify bot commented Dec 12, 2024

Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f06e438
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/675b3b9c47086a0008c070fb
😎 Deploy Preview https://deploy-preview-3334.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ST-DDT ST-DDT added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: animal Something is referring to the animal module labels Dec 12, 2024
@ST-DDT ST-DDT added this to the vAnytime milestone Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.96%. Comparing base (5ec4a6c) to head (f06e438).
Report is 2 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3334      +/-   ##
==========================================
- Coverage   99.97%   99.96%   -0.01%     
==========================================
  Files        2807     2809       +2     
  Lines      217087   217141      +54     
  Branches      969      968       -1     
==========================================
+ Hits       217029   217074      +45     
- Misses         58       67       +9     
Files with missing lines Coverage Δ
src/locales/de/animal/index.ts 100.00% <100.00%> (ø)
src/locales/de/animal/type.ts 100.00% <100.00%> (ø)
src/locales/de/index.ts 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

@ST-DDT ST-DDT requested review from a team December 12, 2024 21:42
@ST-DDT ST-DDT added this pull request to the merge queue Dec 13, 2024
Merged via the queue into faker-js:next with commit 13538a7 Dec 13, 2024
26 checks passed
@ST-DDT
Copy link
Member

ST-DDT commented Dec 13, 2024

Thanks for your contribution ❤️

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c: locale Permutes locale definitions m: animal Something is referring to the animal module p: 1-normal Nothing urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants