-
-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: add usage trend #3374
chore: add usage trend #3374
Conversation
✅ Deploy Preview for fakerjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3374 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2811 2811
Lines 216965 216965
Branches 941 940 -1
==========================================
- Hits 216914 216912 -2
- Misses 51 53 +2 |
Thank you for your contribution! The addition of the usage trend feature is a good idea to provide insights into the popularity of the package. However, I have a few points for discussion:
Please let me know what you think about my concerns. |
Do you have a GitHub repo/issue tracker as well? |
If this is not an official NPM project i think you are supposed to request permission from npm, Inc first to use "npm" in your product name. |
@cwtuan Could you please respond to the above questions? |
Thank you for your thoughtful feedback and for considering my contribution!
I’m open to any further suggestions. Thank you again for your consideration! |
I'm not sure about the location, but IMO the graph should show the downlads of the entire project duration without updates from our time side. Currently it is set to 3 years, so the first few months are already outside of this. Would it be possible to pass a start date or alternatively filter leading zero values from an "alltime"/all graphs? Do you have a GitHub repo/issue tracker as well? |
I think its a cool site when you are comparing libraries like this: https://npm-compare.com/@faker-js/faker,casual,chance,faker/#timeRange=THREE_YEARS As a standalone graph for one library, im not sure it tells me that much other than "there has been steady growth in downloads over the last three years". Also, it's not clear what the y-axis represents. My assumption was daily downloads, but comparing with the official npm stats i think its actually weekly downloads? (We average about 6 million a week or 800K/day). |
I agree with this statement. I'm not opposed to adding it, but we should have someone from the team actually wanting this feature. |
Perhaps instead we could add a new section to awesome-faker called "statistics" and link to various third party sites which shows faker's download and ranking trends? |
Changes done
I appreciate your valuable feedback! Here are the results for @faker-js/faker trend for five years:Here are the results for @faker-js/faker vs faker vs chance vs casual trend for five years: |
I completely understand the concern with the large image in the README. To keep the README clean and still provide valuable info, I've update this PR which link the npm download badge directly to the npm-compare page for faker-js. This way, users can easily access more details without cluttering the README with a large image. I also agree that it could be beneficial to have a dedicated statistics page on the documentation site, where the dynamic usage trends could be displayed more clearly. This would help users get a more visual view of the package's popularity, potentially boosting their confidence in choosing it. |
The changes look great. I had to manually refresh the stats page to reset the cache to actually see the change but it is better now. What do the others think? Does clicking the download button match your expectation of clicking that button? |
Seems okay to me. Gives some more information than repeating the npm link on a second badge. And appreciate the quick turnaround on making changes on your site ! |
In case anybody is interested in collecting the data themselves: https://github.com/npm/registry/blob/main/docs/download-counts.md |
Thanks again for your advice, everyone. |
@cwtuan Thanks for your contribution. If you want to add more registries/package proxies in the future you could add an option which registry to source the data from (maybe also adding them together). Here is a link for metrics from jsdelivr:
The API also return a npm package rank (typerank) and jsdelivr overall rank (rank). You could even build a rank graph by iterating over the weeks/days/months/years you are fetching: https://data.jsdelivr.com/v1/stats/packages/npm/@faker-js/faker?period=2024-01 |
Hi, I’d like to suggest adding a dynamic NPM downloads trend image to the README of faker-js. This image would visually highlight the growth in popularity of the package over the past 3 years, helping new users see that the package is actively maintained and gaining popularity.
As a maintainer of npm-compare.com, a platform offering insights into NPM package trends, I believe this PR could give potential users more confidence in adopting faker-js for their projects. It provides a clear and real-time view of the package's increasing usage.
If there are any additional features from npm-compare.com that could further benefit the faker-js project, I’d be more than happy to implement them as well.
Thank you for considering my suggestion. I look forward to your feedback and the opportunity to contribute to this awesome project!