Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: retry verify tag 3 times #3395

Merged
merged 2 commits into from
Feb 12, 2025
Merged

test: retry verify tag 3 times #3395

merged 2 commits into from
Feb 12, 2025

Conversation

Shinigami92
Copy link
Member

Retries the test 3 times, because locally it errors for me very often when I do a first run.

Looks like this even happens on GitHub CI: https://github.com/faker-js/faker/actions/runs/13203808509/job/36862047625?pr=3394#step:7:3071

@Shinigami92 Shinigami92 added this to the vAnytime milestone Feb 7, 2025
@Shinigami92 Shinigami92 self-assigned this Feb 7, 2025
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 7, 2025 16:29
Copy link

netlify bot commented Feb 7, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit ebd9091
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67acf69a901c60000836f31e
😎 Deploy Preview https://deploy-preview-3395.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Shinigami92 Shinigami92 marked this pull request as draft February 7, 2025 16:30
@Shinigami92 Shinigami92 changed the title test: retry verify example tag 3 times test: retry verify tag 3 times Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (b9a12f5) to head (ebd9091).
Report is 1 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #3395      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2811     2811              
  Lines      216965   216965              
  Branches      942      942              
==========================================
- Hits       216914   216912       -2     
- Misses         51       53       +2     

see 1 file with indirect coverage changes

@Shinigami92 Shinigami92 marked this pull request as ready for review February 7, 2025 16:33
@ST-DDT
Copy link
Member

ST-DDT commented Feb 7, 2025

Pros: Fixes issues with some tests
Cons: Makes the test less useful to detect random errors

I think the cons don't matter that much as the changed tests have a different purpose.

@ST-DDT ST-DDT requested review from a team February 7, 2025 17:11
@ST-DDT ST-DDT enabled auto-merge (squash) February 12, 2025 19:29
@ST-DDT ST-DDT merged commit e28273f into next Feb 12, 2025
23 checks passed
@ST-DDT ST-DDT deleted the test-retry-some-more branch February 12, 2025 19:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants