Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Faker::HarryPotter.spell #1279

Merged
merged 4 commits into from
Jun 11, 2018
Merged

Conversation

A9u
Copy link

@A9u A9u commented Jun 11, 2018

  • Added Faker::HarryPotter.spell
  • Updated locales, docs, tests

@vbrazo vbrazo force-pushed the harry_potter_spell branch from 1244e96 to 816622c Compare June 11, 2018 18:14
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done 👍 Thanks for contributing 🥇

@vbrazo vbrazo merged commit c7f21a0 into faker-ruby:master Jun 11, 2018
@vbrazo vbrazo self-requested a review July 19, 2018 01:21
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
* added spell in Harry Potter
* added new method spell

* updated doc

* Update changelog

* Minor change
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants