Update Faker::Games::SuperSmashBros entries #1658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrazo
approved these changes
Jul 19, 2019
sanikkenway
added a commit
to sanikkenway/faker
that referenced
this pull request
Jul 23, 2019
Update Faker::Games::SuperSmashBros entries (faker-ruby#1658)
michebble
pushed a commit
to michebble/faker
that referenced
this pull request
Feb 16, 2020
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the
Faker::Games::SuperSmashBrosfaker to support the new DLC characters and stages being released this year.As yet, the name of the Hero's stage is unknown. I didn't include Joker's stage, Mementos, in my last PR.