Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add more YARD docs #1769

Merged
merged 8 commits into from
Dec 5, 2019
Merged

Add more YARD docs #1769

merged 8 commits into from
Dec 5, 2019

Conversation

connorshea
Copy link
Member

Adds YARD docs for the following classes:

  • Faker::Ancient
  • Faker::Currency
  • Faker::Color
  • Faker::Fillmurray
  • Faker::Esport
  • Faker::Team
  • Faker::Space
  • Faker::ChuckNorris

@connorshea connorshea mentioned this pull request Sep 29, 2019
Closed
@vbrazo vbrazo force-pushed the master branch 3 times, most recently from a2a9f17 to 4384168 Compare September 30, 2019 07:10
@connorshea
Copy link
Member Author

@vbrazo should I split this PR up into smaller pieces?

vbrazo
vbrazo approved these changes Dec 5, 2019
View reviewed changes
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@vbrazo vbrazo merged commit d2a0914 into faker-ruby:master Dec 5, 2019
@vbrazo
Copy link
Member

vbrazo commented Dec 5, 2019

No, it's ok. Thank you 👍

@connorshea connorshea deleted the add-yard-docs branch December 5, 2019 02:26
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
@vbrazo
Merge pull request faker-ruby#1769 from connorshea/add-yard-docs
a6f79cd 
Add more YARD docs
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@vbrazo vbrazo vbrazo approved these changes

Assignees

@connorshea connorshea

Labels
📘 Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorshea @vbrazo