-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add YARD doc for Faker::Food #1802
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments :) Thanks!
lib/faker/default/food.rb
Outdated
# @example | ||
# Faker::Food.dish #=> "Feijoada" | ||
# | ||
# @faker.version 2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions should be updated to reflect the original versions the methods were added in.
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
Co-Authored-By: Connor Shea <connor.james.shea@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@connorshea @sap1enza good job :) thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* add food docs * Apply suggestions from code review Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Apply suggestions from code review Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Apply suggestions from code review
* add food docs * Apply suggestions from code review Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Apply suggestions from code review Co-Authored-By: Connor Shea <connor.james.shea@gmail.com> * Apply suggestions from code review
Issue#
#1762
Description:
Add complete YARD docs for Faker::Food methods.