Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Translate Canadian provinces for fr-CA #1813

Merged
merged 1 commit into from
Oct 16, 2019

Conversation

Bhacaz
Copy link
Contributor

@Bhacaz Bhacaz commented Oct 16, 2019

I'm french Canadian 🇨🇦 and I saw that the provinces name was still in English for the fr-CA locale, so I take the time to translate them.

Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Canada is awesome man ❤️

Thanks for the translations 👍

@vbrazo vbrazo merged commit 6ee1ad5 into faker-ruby:master Oct 16, 2019
michebble pushed a commit to michebble/faker that referenced this pull request Feb 16, 2020
@Bhacaz Bhacaz deleted the translate_canadien_provinces branch June 18, 2020 19:35
davidmorton0 pushed a commit to davidmorton0/faker that referenced this pull request Jul 12, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants