-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Added Faker::Blood #1960
Added Faker::Blood #1960
Conversation
Hi there, thanks for the Pull Request! Thanks |
Hi @lucasqueiroz, I agree with your suggestion and will do the changes soon. Please confirm the methods and their names.
Let me know if any changes are required. |
@suraj32 The proposed API really looks good! |
Hi @lucasqueiroz . As discussed, I added new methods & updated the description. Let me know if there are any issues with this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suraj32 We can improve the test cases.
Thanks! |
Summary:
Added a new class
Faker::Blood
with the following methods:Faker::Blood.type #=> AB
Faker::Blood.rh_factor #=> -
Faker::Blood.group #=> AB-
Issue#
No-Story
Description:
In my company, there are medical related projects where we store patients data(i.e. Blood group).
In this PR, I added a new class
Faker::Blood
with some important methods. I hope this will be useful in similar projects.