Add YARD docs to Faker::Twitter #1983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made the return type a [Hash]. Please advise if a list of hash keys / value types are preferred, i.e. in this format found in a yard issue: @return [Hash]* :key [String] a key that accepts a string object* :otherkey [Date] the date object to pass in...Personally I would keep it as it is |
Zeragamba
suggested changes
May 17, 2020
Zeragamba
approved these changes
May 17, 2020
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#1762
Description:
Add complete YARD docs for Faker::Twitter methods.