Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add YARD docs to Faker::Types #1999

Merged
merged 2 commits into from
May 20, 2020
Merged

Add YARD docs to Faker::Types #1999

merged 2 commits into from
May 20, 2020

Conversation

danielTiringer
Copy link
Contributor

@danielTiringer danielTiringer commented May 20, 2020 •
edited
Loading

Issue#

#1762

Description:

Add complete YARD docs for Faker::Types methods.

Zeragamba
Zeragamba approved these changes May 20, 2020
View reviewed changes
doc/default/types.md
@@ -23,7 +23,8 @@ Faker::Types.complex_rb_hash(number: 1) #=> {user: {first: "bob", last: "marley"
Faker::Types.complex_rb_hash(number: 2) #=> {user: {first: "bob", last: "marley"}, son: ["damien", "marley"]}

# Random Array
Faker::Types.rb_array #=> ["a", 1, 2, "bob"]
Faker::Types.rb_array #=> ["a"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch :)

@Zeragamba Zeragamba merged commit 7ded0d2 into faker-ruby:master May 20, 2020
@Zeragamba
Copy link
Contributor

Thanks!

@danielTiringer danielTiringer deleted the add-types-docs branch May 20, 2020 20:58
@connorshea connorshea mentioned this pull request May 21, 2020
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Zeragamba Zeragamba Zeragamba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielTiringer @Zeragamba