Add YARD docs to Faker::String #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the symbols listed in the documentation's examples aren't ascii. |
|
I think it's important to show that utf8 characters are returned, and I would prefer to see their visual representation instead of an encoded one. I think we can ask robocop to back off a bit there. |
Zeragamba
approved these changes
May 23, 2020
|
Looks good to me. We should have a looks to see if we can tell YARD to ignore robocop commands. |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
#1762
Description:
Add complete YARD docs for Faker::String methods.