Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

2091 faker drones #2096

Merged
merged 3 commits into from
Aug 13, 2020
Merged

2091 faker drones #2096

merged 3 commits into from
Aug 13, 2020

Conversation

sudeeptarlekar
Copy link
Contributor

Issue#

resolves #2091

Description:

*Added drones in faker. *

@sudeeptarlekar sudeeptarlekar marked this pull request as draft July 29, 2020 16:17
@sudeeptarlekar sudeeptarlekar force-pushed the 2091-faker-drones branch 2 times, most recently from 02e4fc8 to 7fe4436 Compare July 31, 2020 14:28
@sudeeptarlekar sudeeptarlekar marked this pull request as ready for review July 31, 2020 14:31
@sudeeptarlekar sudeeptarlekar force-pushed the 2091-faker-drones branch 2 times, most recently from af75ae5 to 1221863 Compare August 2, 2020 08:22
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a minor comment.

@sudeeptarlekar
Copy link
Contributor Author

@psibi thanks for review, resolved PR comments. Please take a look again.

@sudeeptarlekar
Copy link
Contributor Author

@lucasqueiroz thanks for review, updated units, please take a look again.

@sudeeptarlekar
Copy link
Contributor Author

@psibi, @Zeragamba can we get this merged?

@psibi psibi merged commit f0a84aa into faker-ruby:master Aug 13, 2020
@psibi
Copy link
Member

psibi commented Aug 13, 2020

Thanks for your contribution!

@sudeeptarlekar sudeeptarlekar deleted the 2091-faker-drones branch December 1, 2023 11:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faker is missing drones
3 participants