Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add The Room (2003) to Movies #2134

Merged
merged 11 commits into from
Oct 2, 2020
Merged

Conversation

fiteclub
Copy link
Contributor

@fiteclub fiteclub commented Oct 1, 2020

Issue#

No-Story

Description:

  • Add The Room (2003) to the 'Movies' category
  • Add actors, characters, locations, and quotes

This is the cult classic film The Room (2003), not to be confused with Room (2015).

@fiteclub fiteclub changed the title The room Add The Room (2003) to Movies Oct 1, 2020
@mathisto
Copy link
Contributor

mathisto commented Oct 2, 2020

Finally! A room generator!

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change and good to go!

Copy link
Contributor

@Zeragamba Zeragamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me!

@Zeragamba Zeragamba merged commit 6d83f85 into faker-ruby:master Oct 2, 2020
@Zeragamba
Copy link
Contributor

Thanks!

droznyk pushed a commit to droznyk/faker that referenced this pull request Oct 23, 2020
* Add the Room (2003) to Movies

* Add the Room to README.md

* Remove unnecessary whitespace

* Move README.md changes to unreleased_README.md

Changes can't be in README.md, because these changes aren't
released yet and it will confuse users.
For approved example see comment from vbrazo at
faker-ruby@dc2305d

* Fix spelling & other errors

* Fix problems found by rubocop

* Add Park location

* Add the Room (2003) to Movies

* Remove unreleased_README.md

* Rename Faker::Movies::TheRoom
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
droznyk added a commit to droznyk/faker that referenced this pull request Oct 23, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants