Cleanup games #2155
Merged
Cleanup games #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it's not too much trouble, I'd like to request this PR receive the |
Zeragamba
suggested changes
Oct 13, 2020
doc/fantasy/tolkien.md
Outdated
| @@ -0,0 +1,15 @@ | |||
| # Faker::Fantasy::Tolkien | |||
There was a problem hiding this comment.
slight bit of contamination from #2154. Can we clean this up a bit before merging?
There was a problem hiding this comment.
Ugh. Embarrassing! I'll def sweep up.
There was a problem hiding this comment.
@Zeragamba The deed is done. I rebased and just dropped that commit.
added 16 commits
October 14, 2020 00:52
mathisto
force-pushed
the
cleanup-games
branch
from
9542753 to
18509f5
Compare
mathisto
commented
Oct 14, 2020
mathisto
commented
Oct 14, 2020
Zeragamba
approved these changes
Oct 14, 2020
|
Thanks! |
droznyk
pushed a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
* Add minecraft to README and alphabetize * Reformat dota yaml * Reformat elder_scrolls yaml * Reformat fallout yaml * Compelete fallout character list * Reformat half_life yaml * Reformat heroes yaml * Reformat heroes_of_the_storm yaml * Reformat league of legends yaml * Reformat myst yaml * Reformat overwatch yaml * Reformat pokemon yaml * Fix soul reflect colon and whitespace * Reformat withcer yaml * Reformat zelda yaml * Restore comments to myst. Standardize yaml.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 110b09a.
droznyk
added a commit
to droznyk/faker
that referenced
this pull request
Oct 23, 2020
This reverts commit 110b09a.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription:
This PR cleans up the
Games::family's YAML content.rake reformat_yamland hand-checked for breaking changes during the automation process.Soul Reflect: Ankh(et al.), was being unintentionally interpreted by YAML as the syntax for defining a key-value pair.Games::Falloutgenerator using data scraped from the fandom Fallout wiki.