Various locale specific and other fixes for faker #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary of the changes: - touhou.yml: The current file isn't a valid yaml spec. Use single quote to fix it. - es-AR: Remove redundant entires, the `country_code` should be an array (as consistent with the other formats) - fr: Break `appliance.yml` from `pokemon.yml` as it's a separate one. (Also makes it consistent with the en locale) - ja: Break `animal.yml`, `cat.yml`, `dog.yml`, `overwatch.yml`, `pokemon.yml`, `super_mario.yml`, `zelda.yml` from `creature.yml` and `games.yml`. This makes it consistent with the `en` locale too. - en/music.yml: Move hiphop under music as that's the top level attribute. This also makes it consistent with the other yml convention we follow.
psibi
force-pushed
the
upstream-locale-fixes
branch
from
e3b1e70 to
ab88383
Compare
|
Nice! 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes:
country_codeshould be an array (as consistent with the other formats)appliance.ymlfrompokemon.ymlas it's a separate one. (Also makes it consistent with the en locale)animal.yml,cat.yml,dog.yml,overwatch.yml,pokemon.yml,super_mario.yml,zelda.ymlfromcreature.ymlandgames.yml. This makes it consistent with theenlocale too.Sidenote: These fixes were a result of work here: fakedata-haskell/fakedata#37