Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support https url scheme (add Faker::Internet.secure_url) #460

Closed
wants to merge 1 commit into from
Closed

Support https url scheme (add Faker::Internet.secure_url) #460

wants to merge 1 commit into from

Conversation

juyeong
Copy link

@juyeong juyeong commented Nov 8, 2015

for issue #459
I just added Faker::Internet.secure_url to create fake https url.
Maybe it would be better if url method support all url components like
Faker::Internet.url(scheme: 'https', domain: 'example.org')
but it is not good to make breaking changes. so I just added new method

@juyeong juyeong closed this Nov 23, 2015
@juyeong juyeong reopened this Nov 23, 2015
@DanDobrick
Copy link

@juyeong: why don't you make scheme have default as http?

Faker::Internet.url(host = domain_name, path = "/#{user_name}", scheme = 'http')
Faker::Internet.url(host = domain_name, path = "/#{user_name}", scheme = 'https')

@kaiuhl kaiuhl mentioned this pull request Nov 16, 2016
@stympy
Copy link
Contributor

stympy commented Dec 17, 2016

Closed in favor of #747.

@stympy stympy closed this Dec 17, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants