Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(decl/runners): fix host runner delegation logic #265

Merged

Conversation

ekoops
Copy link
Contributor

@ekoops ekoops commented Jan 22, 2025

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind documentation

/kind tests

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area commands

/area pkg

/area events

What this PR does / why we need it:
This PR fixes host runner delegation logic.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Signed-off-by: Leonardo Di Giovanna <leonardodigiovanna1@gmail.com>
Copy link
Member

@alacuku alacuku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@poiana
Copy link

poiana commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alacuku, ekoops

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link

poiana commented Jan 22, 2025

LGTM label has been added.

Git tree hash: fff3d02d6127b6c8e2c7f1c84b90bfb5385bd708

@poiana poiana merged commit c357657 into falcosecurity:declarative-testing Jan 22, 2025
5 of 6 checks passed
@ekoops ekoops deleted the ekoops/fix-host-runner branch January 22, 2025 10:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants