Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore(ci): libsinsp e2e CI caching #1756

Merged
merged 4 commits into from
Mar 20, 2024

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

/kind feature

Any specific area of the project related to this PR?

/area CI

Does this PR require a change in the driver versions?

What this PR does / why we need it:

This adds build caching in libsinsp e2e CI jobs.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from gnosek and hbrueckner March 18, 2024 15:58
@poiana poiana added the size/M label Mar 18, 2024
@FedeDP FedeDP changed the title chore(ci): libsinsp e2e CI caching wip: chore(ci): libsinsp e2e CI caching Mar 18, 2024
@therealbobo therealbobo force-pushed the libsinsp-e2e-ci-caching branch 2 times, most recently from 76f16f8 to 5680ed3 Compare March 18, 2024 16:55
@therealbobo therealbobo changed the title wip: chore(ci): libsinsp e2e CI caching chore(ci): libsinsp e2e CI caching Mar 18, 2024
@therealbobo therealbobo changed the title chore(ci): libsinsp e2e CI caching wip: chore(ci): libsinsp e2e CI caching Mar 18, 2024
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
@therealbobo therealbobo force-pushed the libsinsp-e2e-ci-caching branch from 5680ed3 to 3703cf4 Compare March 18, 2024 17:03
@therealbobo therealbobo changed the title wip: chore(ci): libsinsp e2e CI caching chore(ci): libsinsp e2e CI caching Mar 18, 2024
@therealbobo therealbobo marked this pull request as ready for review March 18, 2024 17:03
@poiana poiana requested a review from mstemm March 18, 2024 17:03
@therealbobo therealbobo force-pushed the libsinsp-e2e-ci-caching branch from 3703cf4 to b6878d5 Compare March 18, 2024 17:47
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
@therealbobo therealbobo force-pushed the libsinsp-e2e-ci-caching branch 2 times, most recently from 8380826 to cbf924c Compare March 19, 2024 12:06
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
@therealbobo therealbobo force-pushed the libsinsp-e2e-ci-caching branch from cbf924c to 1c3aa68 Compare March 19, 2024 15:32
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this approach!
Wondering whether we can use it and save some precious CI time elsewhere!
/approve

@poiana
Copy link
Contributor

poiana commented Mar 19, 2024

LGTM label has been added.

Git tree hash: 83efe3690e5f2c2a5238914a1eca068c8a1ad873

@FedeDP
Copy link
Contributor

FedeDP commented Mar 19, 2024

/milestone 0.16.0

@poiana poiana added this to the 0.16.0 milestone Mar 19, 2024
@therealbobo
Copy link
Contributor Author

Probably yes but we’ll need to check if there is a storage limit for the gh runners (the build dirs are pretty heavy :/)

Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 6229de5 into falcosecurity:master Mar 20, 2024
43 checks passed
@therealbobo therealbobo deleted the libsinsp-e2e-ci-caching branch March 20, 2024 14:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants