Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(driver/bpf) honor CLANG and LLC from the env #1772

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix(driver/bpf) honor CLANG and LLC from the env #1772

merged 1 commit into from
Mar 28, 2024

Conversation

iurly
Copy link
Contributor

@iurly iurly commented Mar 28, 2024

the configure subsystem currently relies on
clang and llc being available.
However, building drivers in a containerized
environment might actually want to leverage
a specific CLANG version.
So just like we did for CC on the kmod driver,
have those variables passed over to the
configure subsystem.

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@poiana poiana requested review from hbrueckner and leogr March 28, 2024 08:50
@poiana poiana added the size/XS label Mar 28, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Mar 28, 2024

Will double check with driverkit ;)

@iurly
fix(driver/bpf): honor CLANG and LLC from the env
fb43597 
the configure subsystem currently relies on
clang and llc being available.
However, building drivers in a containerized
environment might actually want to leverage
a specific CLANG version.
So just like we did for CC on the kmod driver,
have those variables passed over to the
configure subsystem.

Signed-off-by: Gerlando Falauto <gerlando.falauto@sysdig.com>
@iurly iurly force-pushed the configure-ebpf-clang-llc branch from ddff271 to fb43597 Compare March 28, 2024 09:00
@FedeDP
Copy link
Contributor

FedeDP commented Mar 28, 2024

Driverkit said 🆗

level=DEBUG msg="Built target bpf"
level=DEBUG msg="+ ls -l driver/bpf/probe.o"
level=DEBUG msg="-rw-r--r-- 1 root root 7912008 Mar 28 09:00 driver/bpf/probe.o"

🚀

/milestone 0.16.0

@poiana poiana added this to the 0.16.0 milestone Mar 28, 2024
@FedeDP
Copy link
Contributor

FedeDP commented Mar 28, 2024

Well
/milestone next-driver
indeed

@poiana poiana modified the milestones: 0.16.0, next-driver Mar 28, 2024
FedeDP
FedeDP approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana poiana added the lgtm label Mar 28, 2024
@poiana
Copy link
Contributor

poiana commented Mar 28, 2024

LGTM label has been added.

Git tree hash: 57b0aee0f1646ac6f630541d22a4dd64fae87f98

@iurly
Copy link
Contributor Author

iurly commented Mar 28, 2024

@FedeDP notice I squashed the two commits together as I didn't want two commits to end up in the master branch :-)

Andreagit97
Andreagit97 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, iurly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 209243e into falcosecurity:master Mar 28, 2024
51 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@FedeDP FedeDP FedeDP approved these changes

@Andreagit97 Andreagit97 Andreagit97 approved these changes

@hbrueckner hbrueckner Awaiting requested review from hbrueckner

@leogr leogr Awaiting requested review from leogr

Assignees

@FedeDP FedeDP

@Andreagit97 Andreagit97

Labels
approved area/build area/driver-bpf dco-signoff: yes kind/bug Something isn't working lgtm release-note-none size/XS
Projects
None yet
Milestone
7.1.0+driver
Development

Successfully merging this pull request may close these issues.
4 participants
@iurly @FedeDP @poiana @Andreagit97