Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(libsinsp_e2e): make forking_clone_fs more reliable #1783

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

therealbobo
Copy link
Contributor

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:

/area API-version

/area build

/area CI

/area driver-kmod

/area driver-bpf

/area driver-modern-bpf

/area libscap-engine-bpf

/area libscap-engine-gvisor

/area libscap-engine-kmod

/area libscap-engine-modern-bpf

/area libscap-engine-nodriver

/area libscap-engine-noop

/area libscap-engine-source-plugin

/area libscap-engine-savefile

/area libscap

/area libpman

/area libsinsp

/area tests

/area proposals

Does this PR require a change in the driver versions?

/version driver-API-version-major

/version driver-API-version-minor

/version driver-API-version-patch

/version driver-SCHEMA-version-major

/version driver-SCHEMA-version-minor

/version driver-SCHEMA-version-patch

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@FedeDP
Copy link
Contributor

FedeDP commented Apr 8, 2024

[ FAILED ] sys_call_test.forking_clone_fs

💀

@therealbobo therealbobo changed the title fix(libsinsp_e2e): make forking_clone_fs more reliable [wip]: fix(libsinsp_e2e): make forking_clone_fs more reliable Apr 8, 2024
@therealbobo therealbobo force-pushed the fix-fork-test branch 3 times, most recently from 1ab03ae to 96fea07 Compare April 9, 2024 09:03
@poiana poiana added size/M and removed size/S labels Apr 9, 2024
@Andreagit97 Andreagit97 added this to the 0.16.0 milestone Apr 9, 2024
@therealbobo therealbobo force-pushed the fix-fork-test branch 3 times, most recently from af5d34d to 7354881 Compare April 9, 2024 16:40
@poiana poiana added size/S and removed size/M labels Apr 9, 2024
@therealbobo therealbobo force-pushed the fix-fork-test branch 4 times, most recently from a6d5874 to 1ce9a95 Compare April 9, 2024 19:06
Signed-off-by: Roberto Scolaro <roberto.scolaro21@gmail.com>
@therealbobo therealbobo changed the title [wip]: fix(libsinsp_e2e): make forking_clone_fs more reliable fix(libsinsp_e2e): make forking_clone_fs more reliable Apr 10, 2024
Copy link
Member

@Andreagit97 Andreagit97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 10, 2024

LGTM label has been added.

Git tree hash: bb5560280bbeb234555f6d44be371a5ba88f6b28

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP, therealbobo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana poiana merged commit 59a7627 into falcosecurity:master Apr 10, 2024
42 of 43 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants