test(userspace/libsinsp): add cases for formatters and minor improvements #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/milestone 0.16.0 |
LucaGuerra
reviewed
Apr 9, 2024
LucaGuerra
reviewed
Apr 9, 2024
LucaGuerra
reviewed
Apr 9, 2024
|
Thank you! Just some minor comments |
jasondellaluce
force-pushed
the
test/formatters-filters-improvement
branch
from
d29e090 to
c4a1b84
Compare
|
Thanks Luca! Accepted all your suggestions |
LucaGuerra
approved these changes
Apr 9, 2024
|
LGTM label has been added. Git tree hash: 8d692bc1286f87a4d63d38c92ceba773272054e8
|
|
@jasondellaluce can you rebase to fix ci? |
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com> Co-authored-by: Luca Guerra <luca@guerra.sh> Signed-off-by: Jason Dellaluce <jasondellaluce@gmail.com>
jasondellaluce
force-pushed
the
test/formatters-filters-improvement
branch
from
c4a1b84 to
0fa9ce0
Compare
LucaGuerra
approved these changes
Apr 10, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Andreagit97, jasondellaluce, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 13310cf01d370f760bd2f1661cfe289d9fecfab3
|
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
I realized that we don't have coverage in our output formatting system, which is also the construct used by Falco for formatting output strings and fields when security rules are triggered. This PR achieves decent coverage, and also adds minor improvements to the test suite for what concerns filters.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: