fix: class definitions with duplicate names #1886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Federico Aponte <federico.aponte@sysdig.com>
federico-sysdig
force-pushed
the
fix-duplicate-class-definitions
branch
from
b3edf06 to
3233a22
Compare
|
/milestone 0.18.0 |
|
LGTM label has been added. Git tree hash: c7afe1021aa0d89352f9f574fbd1789d36527ed4
|
|
@hbrueckner @LucaGuerra |
LucaGuerra
approved these changes
Jun 24, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, federico-sysdig, LucaGuerra The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area build
Does this PR require a change in the driver versions?
No
What this PR does / why we need it:
The struct
plugin_stateis defined several times with different definitions in different compilation units. This would not be a problem, but if you try to apply link-time optimization (LTO) the linker complains and raises an error because the one-definition rule (ODR) has been broken. The fix is easy, the duplicate definitions are only used within their .cpp file and can be enclosed in an anonymous namespace, so that they'll have internal linkage.This is one of several changes to make
falcosecurity-libs(and its client code) amenable to LTO, should one want to experiment with it. There are other such cases that will be handled in other PR's.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
reinterpret_castrather than an generic C-style cast and similar.statichas been removed from functions that fell inside the anonymous namespace as this already gives them internal linkage.Does this PR introduce a user-facing change?: