new(userspace/libsinsp): expose threadinfo cgroups in plugins table api #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able API. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
…pair_t values. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
poiana
added
release-note
do-not-merge/work-in-progress
dco-signoff: yes
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Instead, rely on a new table entry adapter, `pair_table_entry_adapter`. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
FedeDP
force-pushed
the
new/expose_cgroups_plugins_table_api
branch
from
dceb0b7 to
2364176
Compare
FedeDP
commented
Oct 10, 2024
FedeDP
commented
Oct 10, 2024
| @@ -443,10 +443,10 @@ class SINSP_PUBLIC sinsp_threadinfo : public libsinsp::state::table_entry { | |||
| bool m_exe_lower_layer; ///< True if the executable file belongs to lower layer in overlayfs | |||
| bool m_exe_from_memfd; ///< True if the executable is stored in fileless memory referenced by | |||
| ///< memfd | |||
| std::vector<std::string> m_args; ///< Command line arguments (e.g. "-d1") | |||
| std::vector<std::string> m_env; ///< Environment variables | |||
| std::unique_ptr<cgroups_t> m_cgroups; ///< subsystem-cgroup pairs | |||
There was a problem hiding this comment.
Had to revert this change... (see #473 for the initial changeset)
FedeDP
commented
Oct 10, 2024
| @@ -659,6 +660,10 @@ class SINSP_PUBLIC sinsp_threadinfo : public libsinsp::state::table_entry { | |||
| bool m_parent_loop_detected; | |||
| libsinsp::state::stl_container_table_adapter<decltype(m_args)> m_args_table_adapter; | |||
| libsinsp::state::stl_container_table_adapter<decltype(m_env)> m_env_table_adapter; | |||
| libsinsp::state::stl_container_table_adapter< | |||
There was a problem hiding this comment.
This is a bit ugly because we need to enforce the specific value unwrapping class (the second entry).
|
/milestone 0.19.0 for a review :) i want to gather feedback asap (eg: change field names, or anything else i got wrong) |
|
@FedeDP: GitHub didn't allow me to request PR reviews from the following users: mrgian. Note that only falcosecurity members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2107 +/- ##
==========================================
+ Coverage 73.69% 74.46% +0.76%
==========================================
Files 253 254 +1
Lines 31914 33316 +1402
Branches 5642 5718 +76
==========================================
+ Hits 23519 24808 +1289
- Misses 8395 8481 +86
- Partials 0 27 +27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
FedeDP
changed the title
|
/hold |
|
Also, should i bump plugin api version? |
…` and `second`. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
jasondellaluce
approved these changes
Oct 21, 2024
|
/unhold |
LucaGuerra
approved these changes
Oct 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
Any specific area of the project related to this PR?
/area libsinsp
/area tests
Does this PR require a change in the driver versions?
What this PR does / why we need it:
This is needed to ensure k8smeta plugin can improve its perf.
Also, it is mandatory for the possible container engine as a plugin refactor because we will need to access thread cgroups from the plugin.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Most of the lines changes come from the new test. Most of real code is under table_adapters.h for the new
std::pairadapter.Does this PR introduce a user-facing change?: