new(userspace/libsinsp): expose get_owner_last_error in plugin's capture listening capability
#2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pture listening capability. Signed-off-by: Federico Di Pierro <nierro92@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/milestone 0.19.0 |
FedeDP
commented
Nov 5, 2024
| // Return a string with the error that was last generated by the plugin's | ||
| // owner, or NULL if no error is present. | ||
| // The string pointer is owned by the plugin's owenr. | ||
| const char* (*get_owner_last_error)(ss_plugin_owner_t* o); |
There was a problem hiding this comment.
This is needed to expose table_reader and table_writer from plugin sdks.
FedeDP
commented
Nov 5, 2024
| @@ -371,7 +371,10 @@ void sinsp::open_common(scap_open_args* oargs, | |||
| // notify registered plugins of capture open | |||
| for(auto& p : m_plugin_manager->plugins()) { | |||
| if(p->caps() & CAP_CAPTURE_LISTENING) { | |||
| p->capture_open(); | |||
| if(!p->capture_open()) { | |||
There was a problem hiding this comment.
Manage errors in capture_open/close.
Perf diff from master - unit testsHeap diff from master - unit testsHeap diff from master - scap fileBenchmarks diff from master |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2147 +/- ##
==========================================
- Coverage 74.69% 74.68% -0.02%
==========================================
Files 254 254
Lines 33502 33508 +6
Branches 5746 5753 +7
==========================================
Hits 25025 25025
- Misses 8477 8483 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LucaGuerra
approved these changes
Nov 5, 2024
jasondellaluce
approved these changes
Nov 5, 2024
leogr
approved these changes
Nov 5, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
Any specific area of the project related to this PR?
/area libsinsp
Does this PR require a change in the driver versions?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: