Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update pre-commit stages #2169

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

Andreagit97
Copy link
Member

What type of PR is this?

/kind cleanup

Any specific area of the project related to this PR?

/area build

Does this PR require a change in the driver versions?
no

What this PR does / why we need it:

Address pre-commit warnings:

[WARNING] hook id `cmake-format` uses deprecated stage names (commit) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.
[WARNING] hook id `clang-format` uses deprecated stage names (commit) which will be removed in a future version.  run: `pre-commit migrate-config` to automatically fix this.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@Andreagit97 Andreagit97 added this to the 0.20.0 milestone Nov 22, 2024
@poiana poiana requested review from gnosek and hbrueckner November 22, 2024 16:41
@Andreagit97 Andreagit97 changed the title chore: updare pre-commit stages chore: update pre-commit stages Nov 22, 2024
@poiana poiana added the size/XS label Nov 22, 2024
Signed-off-by: Andrea Terzolo <andreaterzolo3@gmail.com>
Copy link

Perf diff from master - unit tests

     2.27%     -0.77%  [.] std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >::_M_construct<char const*>
     0.52%     +0.76%  [.] std::vector<sinsp_evt_param, std::allocator<sinsp_evt_param> >::emplace_back<sinsp_evt*, unsigned int&, char const*, unsigned long&>
     3.72%     +0.74%  [.] sinsp_parser::process_event
     8.86%     +0.71%  [.] sinsp_parser::reset
     5.52%     +0.59%  [.] sinsp_evt::get_type
     1.39%     -0.51%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::find
     3.76%     -0.50%  [.] gzfile_read
     2.95%     -0.48%  [.] sinsp_thread_manager::get_thread_ref
     6.65%     +0.46%  [.] sinsp::next
     2.28%     -0.41%  [.] std::_Hashtable<long, std::pair<long const, std::shared_ptr<sinsp_threadinfo> >, std::allocator<std::pair<long const, std::shared_ptr<sinsp_threadinfo> > >, std::__detail::_Select1st, std::equal_to<long>, std::hash<long>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<false, false, true> >::_M_find_before_node

Heap diff from master - unit tests

peak heap memory consumption: -438B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Heap diff from master - scap file

peak heap memory consumption: 0B
peak RSS (including heaptrack overhead): 0B
total memory leaked: 0B

Benchmarks diff from master

Comparing gbench_data.json to /root/actions-runner/_work/libs/libs/build/gbench_data.json
Benchmark                                                         Time             CPU      Time Old      Time New       CPU Old       CPU New
----------------------------------------------------------------------------------------------------------------------------------------------
BM_sinsp_split_mean                                            +0.0217         +0.0217           143           146           143           146
BM_sinsp_split_median                                          +0.0211         +0.0211           143           146           143           146
BM_sinsp_split_stddev                                          +0.0883         +0.0923             2             2             2             2
BM_sinsp_split_cv                                              +0.0651         +0.0691             0             0             0             0
BM_sinsp_concatenate_paths_relative_path_mean                  +0.0744         +0.0742            60            64            60            64
BM_sinsp_concatenate_paths_relative_path_median                +0.0959         +0.0957            59            65            59            65
BM_sinsp_concatenate_paths_relative_path_stddev                +1.0490         +1.0463             1             2             1             2
BM_sinsp_concatenate_paths_relative_path_cv                    +0.9071         +0.9050             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_mean                     -0.0190         -0.0191            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_median                   -0.0224         -0.0225            25            25            25            25
BM_sinsp_concatenate_paths_empty_path_stddev                   -0.7781         -0.7752             0             0             0             0
BM_sinsp_concatenate_paths_empty_path_cv                       -0.7738         -0.7709             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_mean                  -0.0038         -0.0040            63            63            63            63
BM_sinsp_concatenate_paths_absolute_path_median                -0.0073         -0.0074            63            62            63            62
BM_sinsp_concatenate_paths_absolute_path_stddev                +0.6572         +0.6558             0             0             0             0
BM_sinsp_concatenate_paths_absolute_path_cv                    +0.6635         +0.6625             0             0             0             0
BM_sinsp_split_container_image_mean                            +0.0122         +0.0120           385           390           385           390
BM_sinsp_split_container_image_median                          +0.0145         +0.0141           385           391           385           390
BM_sinsp_split_container_image_stddev                          -0.5420         -0.5442             3             1             3             1
BM_sinsp_split_container_image_cv                              -0.5475         -0.5496             0             0             0             0

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.82%. Comparing base (2e1c5b6) to head (43c2595).
Report is 58 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2169   +/-   ##
=======================================
  Coverage   74.82%   74.82%           
=======================================
  Files         254      254           
  Lines       33519    33519           
  Branches     5749     5749           
=======================================
  Hits        25079    25079           
  Misses       8440     8440           
Flag Coverage Δ
libsinsp 74.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@FedeDP FedeDP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@poiana
Copy link
Contributor

poiana commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Andreagit97, FedeDP

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@poiana
Copy link
Contributor

poiana commented Nov 25, 2024

LGTM label has been added.

Git tree hash: 694aeb77c70e670b7df36d773335996d21e07db2

@poiana poiana merged commit 0b5ccc0 into falcosecurity:master Dec 11, 2024
49 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants