Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

shutdown before start to avoid race conditions #260

Merged
merged 4 commits into from
Dec 23, 2022
Merged

shutdown before start to avoid race conditions #260

merged 4 commits into from
Dec 23, 2022

Conversation

thomas-gerber
Copy link
Contributor

@thomas-gerber thomas-gerber commented Nov 19, 2022 •
edited
Loading

If Faros CE is running when one launches start, the script exits.
This ensure a consistent interaction between services on start (e.g. metabase container does not start until db is configured)

Type of change

(Delete what does not apply)

  • Bug fix (non-breaking change which fixes an issue)

Checklist

(Delete what does not apply)

  • Have you checked to there aren't other open Pull Requests for the same update/change?
  • Have you lint your code locally before submission?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

@thomas-gerber
More aggressive healthcheck
2e4f02f 
If Faros CE is running when one launches start,
it is shut down prior to composing up.
This ensure a consistent interaction between services on start
(e.g. metabase container does not start until db is configured)
tovbinm
tovbinm reviewed Nov 19, 2022
View reviewed changes
start.sh Outdated Show resolved Hide resolved
@thomas-gerber
Separates stop and start commands.
027a197 
Note that `docker compose down` command will only stop services
listed in the compose file of the folder
tovbinm
tovbinm reviewed Dec 23, 2022
View reviewed changes
stop.sh Show resolved Hide resolved
@thomas-gerber thomas-gerber merged commit b6b40aa into main Dec 23, 2022
@thomas-gerber thomas-gerber deleted the finer_healthcheck branch December 23, 2022 04:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@tovbinm tovbinm tovbinm approved these changes

@cjwooo cjwooo Awaiting requested review from cjwooo cjwooo is a code owner

@ypc-faros ypc-faros Awaiting requested review from ypc-faros ypc-faros is a code owner

@ogusak ogusak Awaiting requested review from ogusak ogusak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-gerber @tovbinm