Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: allow LocalSpan::add_property() when the local parent is a Span #33

Merged
merged 4 commits into from
Aug 16, 2024

Conversation

andylokandy
Copy link
Collaborator

Closes #32

@andylokandy andylokandy requested a review from zhongzc August 15, 2024 07:14
Copy link
Collaborator

@zhongzc zhongzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@andylokandy andylokandy changed the title allow to LocalSpan::add_property() when the local parent is a Span allow LocalSpan::add_property() when the local parent is a Span Aug 15, 2024
@andylokandy andylokandy changed the title allow LocalSpan::add_property() when the local parent is a Span feat: allow LocalSpan::add_property() when the local parent is a Span Aug 15, 2024
@andylokandy andylokandy merged commit 64fd1d2 into fast:main Aug 16, 2024
11 checks passed
@andylokandy andylokandy deleted the dev5 branch August 16, 2024 09:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding properties to a Span after it's attached to a future
2 participants