Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix frontend tests #436

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Conversation

jean-the-coder
Copy link
Contributor

Description

Small PR to fix the failing frontend tests. I also added a few small changes in CONTRIBUTING.md for things I came across while getting the repo up and running.

Changes

  • Added a few small comments/clarifications to CONTRIBUTING.md for things that gave me a tiny pause setting up
  • Updated failing frontend tests. Mostly adding providers and imports to the TestBed configuration in the tests.

@CLAassistant
Copy link

CLAassistant commented Mar 1, 2024

CLA assistant check
All committers have signed the CLA.

@jean-the-coder jean-the-coder marked this pull request as ready for review March 1, 2024 02:36
@AnalogJ
Copy link
Member

AnalogJ commented Mar 1, 2024

fantastic work @jean-the-coder 🥳
Thanks so much for contributing!

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.99%. Comparing base (4484032) to head (0f36fd3).
Report is 91 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #436      +/-   ##
==========================================
+ Coverage   20.84%   20.99%   +0.14%     
==========================================
  Files         278      288      +10     
  Lines       16649    17285     +636     
  Branches      581      615      +34     
==========================================
+ Hits         3471     3629     +158     
- Misses      12860    13320     +460     
- Partials      318      336      +18     
Flag Coverage Δ
unittests 20.99% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnalogJ AnalogJ merged commit 05a6840 into fastenhealth:main Mar 1, 2024
4 of 5 checks passed
@jean-the-coder jean-the-coder deleted the fix-frontend-tests branch March 1, 2024 04:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants