Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I fixed the image fallback directive to not infinitely loop in #444, I accidentally updated the fallback path to
/assets/images/no-image.svg
instead ofassets/images/no-image.svg
. This is making the path be treated as an absolute and is ignoring the configured base href of/web/
.Didn't notice because storybook doesn't run under a base href. I wasn't able to figure out a way to make storybook run under a base ref like the normal site does, but if you run the site locally in sandbox mode you can see the difference between main and this branch as the Dynamic Health IT and AdvancedMD sources do not have images.
Changes
/
in asset path of image fallbackScreenshots
before:
after: