Issue276 plus/minus handling in parse_infnan #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running tests. Some of the CI failures are not related (caused by) this PR, and can be handled separately. |
|
I missed to do the "one thing" that the pull request template said I should to, formatting the code according to clang-format. 😅 |
Yeah but that's not a blocking issue because we can always do it later. |
|
Running tests. |
|
I am merging this. The failing tests are unrelated and will be fixed later. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"-+NNNN" should fail to parse, regardless of what NNNN is and regardless if FASTFLOAT_ALLOWS_LEADING_PLUS is defined.
Fixes #276