-
-
Notifications
You must be signed in to change notification settings - Fork 36
Rename Module #110
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rename Module #110
Conversation
This commit renames the module in accordance with the discussion in fastify/fastify/issues/3733 .
@adrai I don't have permission to publish this module. Can you give me access to the npm or move the package to the fastify org? |
It may be I missed something, but this is not a fastify-* plugin... @mcollina did I miss something? |
It is in the fastify/fastify#3733 list. So, I was assuming it to be renamed as well |
As long as Fastify provides an But if for some organizational reason this needs to be renamed too, ok... I remain at your disposal and waiting for a "final" decision... |
Let's wait for someone else from @fastify/core to comment then |
I think it should still be renamed to be under the Regardless, packages in the Fastify GitHub org should be maintainable by Fastify team members. At the moment, only @adrai and @mcollina have access to the npm package. Add me, |
I'm ok with it... |
The old, and new, module is now in the Fastify npm org. @RafaelGSS you have access to publish. |
Done! @adrai Can you please merge it and generate the release notes for that? Reference: https://github.com/fastify/fastify-schedule/releases/tag/v2.0.0 |
fyi: I just made some fixes in the readme and created a new release: https://github.com/fastify/aws-lambda-fastify/releases/tag/v3.0.0 |
No. You retain the ability to publish this module. |
ok, I was confused, because I'm not listed here: https://www.npmjs.com/package/@fastify/aws-lambda |
Please check your email that is associated with npmjs.com. |
I don't want to pollute the discussion here, I sent you an email... |
This pull request renames the module according to the discussion in
fastify/fastify#3733.
Note that the deprecation module has already been published and that the
code for it does not exist in this repository. The code for the published
deprecation module was generated by https://github.com/fastify/deprecate-modules
and run on @RafaelGSS local system.
Coordinating the drastic changes to the code for the module deprecation and
then restoring the code for the module renaming would have been extremely
difficult and prohibitively tedious.
Important: no further releases should be added to the old major version.