Skip to content

Rename Module #110

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 5, 2022
Merged

Rename Module #110

merged 1 commit into from
Jun 5, 2022

Conversation

RafaelGSS
Copy link
Member

This pull request renames the module according to the discussion in
fastify/fastify#3733.

Note that the deprecation module has already been published and that the
code for it does not exist in this repository. The code for the published
deprecation module was generated by https://github.com/fastify/deprecate-modules
and run on @RafaelGSS local system.

Coordinating the drastic changes to the code for the module deprecation and
then restoring the code for the module renaming would have been extremely
difficult and prohibitively tedious.

Important: no further releases should be added to the old major version.

This commit renames the module in accordance with the discussion in
fastify/fastify/issues/3733 .
@RafaelGSS
Copy link
Member Author

@adrai I don't have permission to publish this module. Can you give me access to the npm or move the package to the fastify org?

@adrai
Copy link
Member

adrai commented Jun 4, 2022

It may be I missed something, but this is not a fastify-* plugin...

@mcollina did I miss something?

@RafaelGSS
Copy link
Member Author

RafaelGSS commented Jun 4, 2022

It is in the fastify/fastify#3733 list. So, I was assuming it to be renamed as well

@adrai
Copy link
Member

adrai commented Jun 4, 2022

As long as Fastify provides an .inject() function we have not to deprecate anything (technically)...

But if for some organizational reason this needs to be renamed too, ok...
btw: I'm not part of the npm fastify org...

I remain at your disposal and waiting for a "final" decision...

@RafaelGSS
Copy link
Member Author

Let's wait for someone else from @fastify/core to comment then

@jsumners
Copy link
Member

jsumners commented Jun 4, 2022

I think it should still be renamed to be under the @fastify npm scope. Whether or not the deprecation tooling I devised for plugins works, I have no idea.

Regardless, packages in the Fastify GitHub org should be maintainable by Fastify team members. At the moment, only @adrai and @mcollina have access to the npm package. Add me, @jsumners on npmjs.com, and I will take care of getting the package added to the org and permissions set so that this PR can be completed.

@mcollina
Copy link
Member

mcollina commented Jun 5, 2022

@adrai I think it would be good to rename. The idea behind @fastify plugin is to have them be official ones.

I'm also ok if you prefer not to do this, this is not technically a plugin and @adrai is the lead maintainer of this one.

(it's outside of the @fastify/plugins team).

@adrai
Copy link
Member

adrai commented Jun 5, 2022

I'm ok with it...
@jsumners you should now have access to npm

@jsumners
Copy link
Member

jsumners commented Jun 5, 2022

The old, and new, module is now in the Fastify npm org. @RafaelGSS you have access to publish.

@RafaelGSS
Copy link
Member Author

The old, and new, module is now in the Fastify npm org. @RafaelGSS you have access to publish.

Done!

@adrai Can you please merge it and generate the release notes for that?

Reference: https://github.com/fastify/fastify-schedule/releases/tag/v2.0.0

@adrai adrai merged commit d14c185 into fastify:master Jun 5, 2022
adrai added a commit that referenced this pull request Jun 5, 2022
@adrai
Copy link
Member

adrai commented Jun 5, 2022

fyi: I just made some fixes in the readme and created a new release: https://github.com/fastify/aws-lambda-fastify/releases/tag/v3.0.0
So if I understood correctly, next time this modules needs to be updated (published to npm) someone else needs to do it, right?

@jsumners
Copy link
Member

jsumners commented Jun 5, 2022

No. You retain the ability to publish this module.

@adrai
Copy link
Member

adrai commented Jun 5, 2022

No. You retain the ability to publish this module.

ok, I was confused, because I'm not listed here: https://www.npmjs.com/package/@fastify/aws-lambda
image

@jsumners
Copy link
Member

jsumners commented Jun 5, 2022

Please check your email that is associated with npmjs.com.

@adrai
Copy link
Member

adrai commented Jun 5, 2022

Please check your email that is associated with npmjs.com.

I don't want to pollute the discussion here, I sent you an email...

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants