perf: use regexp in string escaping #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ivan-tymoshenko
force-pushed
the
use-regexp-for-string-escaping
branch
from
c6408cf to
c683091
Compare
Uzlopak
reviewed
Oct 15, 2022
Uzlopak
reviewed
Oct 15, 2022
RafaelGSS
reviewed
Oct 15, 2022
| @@ -94,6 +97,10 @@ module.exports = class Serializer { | |||
| str = str.toString() | |||
| } | |||
|
|
|||
| if (!STR_ESCAPE.test(str)) { | |||
There was a problem hiding this comment.
Could you please include a comment above this line telling why it's needed?
Eomm
reviewed
Oct 16, 2022
| @@ -94,6 +97,11 @@ module.exports = class Serializer { | |||
| str = str.toString() | |||
| } | |||
|
|
|||
| // Fast escape chars check | |||
| if (!STR_ESCAPE.test(str)) { | |||
There was a problem hiding this comment.
This new check does not execute the str.length < 42 optimization. Is this wanted or could we go even faster?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do you want some perf upgrades? I've got something for you.