docs: move data.fields line in README

[frapan]

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[frapan]

Fixes #252

[climba03003]

(available only AFTER the stream is consumed)
The above sentence is not always true. I do not want to give wrong explanation to the client just to reduce the issue.

Instead, I would like someone to explain more on how stream or busboy operate and create a Q&A section.

e.g.
busboy consume the multipart in serial order (stream), the order of form field is VERY IMPORTANT to how fastify-multipart can display the fields to you. We would recommend you to place the value fields first before any of the file fields. It can ensure your fields will be accessible before start consuming any file.

[darkgl0w]

Note: if the file stream that is provided by data.file is not consumed, like in the example below with the usage of pump, the promise will not be fulfilled at the end of the multipart processing. This behavior is inherited from @fastify/busboy.

There is a note about this in the README.md just after the example

I would suggest that you add another note with the explaining sentence proposed by @climba03003 instead.

[frapan]

Thank you for your explanations.

I reverted to the original file and added the note of @climba03003 with a small addition:

Note about data.fields: busboy consumes the multipart in serial order (stream). Therefore, the order of form fields is VERY IMPORTANT to how fastify-multipart can display the fields to you.
We would recommend you to place the value fields first before any of the file fields.
It can ensure your fields will be accessible before start consuming any file.
If you cannot control the order of the placed fields, be sure to read data.fields AFTER consuming the stream, or it will contain only the fields parsed at that moment.

I also realized that the following note was duplicated:

Note: if the file stream that is provided by data.file is not consumed, like in the example below with the usage of pump, the promise will not be fulfilled at the end of the multipart processing. This behavior is inherited from @fastify/busboy.

So I deleted the one that was in the wrong (imho) position.

What do you think?

[mccare]

On a related note, the documentation here https://github.com/fastify/busboy#busboy-special-events mentions that you can also just use file.resume(). If that is correct, I would also add it to the documentation here. WDYT?

[climba03003]

On a related note, the documentation here https://github.com/fastify/busboy#busboy-special-events mentions that you can also just use file.resume(). If that is correct, I would also add it to the documentation here. WDYT?

I think it is a separate issue.

[climba03003]

Can you kindly help to check the sentence for us?
cc @Fdawgs

[climba03003]

LGTM.

[darkgl0w]

LGTM with code review suggestions applied.

[mcollina]

@Fdawgs are you ok now?

[Fdawgs]

@Fdawgs are you ok now?

All gravy now