Update tests to use node:test, remove tap

[bencoder]

Updates tests to use node:test
Remove tap
Converted tests to async/await style over callbacks and removed t.plan(x) statements where appropriate

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[Uzlopak]

Yeah the windows test fails. Maybe simplest solution: change file extensions of all test files from .js to .test.js or maybe adding ./ to the npm script?!

[gurgunday]

Hi, thanks a lot for the PR!

Please:

1. Install c8
2. Change the test:unit command to c8 --100 node --test
3. As @Uzlopak said, for consistency, it would be great if you could add .test. to the test files

[dancastillo]

Can you add back the t.plan to the tests node:test does support test count assertions ref

[bencoder]

@dancastillo I've removed them where they are not adding anything - they only really make sense when you have assertions in callbacks or conditional statements - everywhere I've removed them has been where I've changed to using await so the assertions will always run and setting t.plan just seems like extra friction.

If they should be a standard for fastify tests though then I can add them back if necessary

[dancastillo]

@bencoder That makes sense to me! As for the standard with Fastify tests, I believe we have them in place for most of our tests but like you mention likely for callbacks or conditionals

I'll defer it to @Uzlopak or @gurgunday to confirm whether it's a strict requirement or is okay

[jsumners]

I would reserve plans for tests of asynchronous operations.

[gurgunday]

lgtm

[dancastillo]

Looks like there is no error defined on await fastify.inject(...) response ref

So this below will never fail.

t.assert.ifError(response.error)

Can we update all similar asserts to below to validate we received a truthy response

  t.assert.ok(response)

[dancastillo]

LGTM