Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: use latest node version #149

Merged
merged 1 commit into from
Jan 6, 2025
Merged

refactor: use latest node version #149

merged 1 commit into from
Jan 6, 2025

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Jan 6, 2025

This PR enables the check-latest option for all action/setup-node steps, which ensures that the latest Node version is used that satisfies the version spec.

I.e. whenever we're using a version like 22, 22.x or lts/* it'll ensure we're using 22.12.0 (at time of writing).

This avoids an old cached version from being used in actions.
See https://github.com/actions/setup-node?tab=readme-ov-file#usage

We'll want this to get 22.13.0 when it becomes available to fix nodejs/node#56137, which is currently plaguing our CI jobs across most repos, otherwise we may still be using a cached version of 22.12.0.

Checklist

Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fdawgs Fdawgs merged commit 0da673d into main Jan 6, 2025
1 check passed
@Fdawgs Fdawgs deleted the chore/check-latest branch January 6, 2025 12:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
2 participants