Skip to content

Fixes share issue with version command #83

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 12 commits into from
Aug 31, 2021
Merged

Fixes share issue with version command #83

merged 12 commits into from
Aug 31, 2021

Conversation

etagwerker
Copy link
Member

Hey,

This PR fixes #81.

Please check it out.

Thanks!

I will abide by the code of conduct.

@etagwerker etagwerker requested a review from bronzdoc August 31, 2021 01:35
@etagwerker etagwerker requested a review from a team as a code owner August 31, 2021 01:35
@codecov
Copy link

codecov bot commented Aug 31, 2021

Codecov Report

Merging #83 (94e0508) into main (730e7eb) will increase coverage by 2.70%.
The diff coverage is 100.00%.

❗ Current head 94e0508 differs from pull request most recent head c80e274. Consider uploading reports for the commit c80e274 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
+ Coverage   95.50%   98.21%   +2.70%     
==========================================
  Files          24       24              
  Lines         445      448       +3     
==========================================
+ Hits          425      440      +15     
+ Misses         20        8      -12     
Impacted Files Coverage Δ
test/lib/skunk/rubycritic/analysed_module_test.rb 100.00% <ø> (ø)
lib/skunk/cli/application.rb 100.00% <100.00%> (ø)
lib/skunk/cli/commands/help.rb 100.00% <100.00%> (ø)
lib/skunk/cli/commands/shareable.rb 100.00% <100.00%> (ø)
lib/skunk/cli/commands/version.rb 100.00% <100.00%> (+100.00%) ⬆️
test/lib/skunk/cli/commands/help_test.rb 100.00% <100.00%> (ø)
lib/skunk/cli/options/argv.rb 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 730e7eb...c80e274. Read the comment docs.

@etagwerker etagwerker changed the title Fixes/share issue Fixes share issue with version command Aug 31, 2021
Copy link
Contributor

@bronzdoc bronzdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bronzdoc bronzdoc merged commit 948e79e into main Aug 31, 2021
@etagwerker etagwerker deleted the fixes/share-issue branch April 27, 2022 15:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

execute ': undefined method `share'
2 participants