Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update wsgi.py #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update wsgi.py #166

wants to merge 1 commit into from

Conversation

isaac2077
Copy link

Copy link

@VincentK-Titandc VincentK-Titandc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
Thanks for the fix, this is a critical issue since eventlet 0.30.3+ actually broke compatibility with old API!
However, this proposal is not retro compatible with older eventlet versions, I suggested some modifications for this purpose.
BR.

@@ -113,7 +113,7 @@ class _AlreadyHandledResponse(Response):
import eventlet
if version.parse(eventlet.__version__) >= version.parse("0.30.3"):
import eventlet.wsgi
_ALREADY_HANDLED = getattr(eventlet.wsgi, "ALREADY_HANDLED", None)
_ALREADY_HANDLED = getattr(getattr(eventlet.wsgi, "WSGI_LOCAL", None), "already_handled", None)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should instead take a similar approach than the fix pushed in gunicorn project here. Here is an example:

EVENTLET_WSGI_LOCAL = getattr(eventlet.wsgi, "WSGI_LOCAL", None)
EVENTLET_ALREADY_HANDLED = getattr(eventlet.wsgi, "ALREADY_HANDLED", None)
...
if getattr(EVENTLET_WSGI_LOCAL, "already_handled", None):
    _ALREADY_HANDLED = getattr(EVENTLET_WSGI_LOCAL, "already_handled", False)
else:
    _ALREADY_HANDLED = EVENTLET_ALREADY_HANDLED

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your comment help a lot, thank you👍

@VincentK-Titandc
Copy link

VincentK-Titandc commented Jun 7, 2022

Hi all, @anarkiwi,
Is ryu's development dead at this point? did everyone just switched to FAUCET?
It would be nice if someone can clarify a bit, I mean I won't spent more time trying to solve issues if the project is dead.
Thanks.

@anarkiwi
Copy link
Member

anarkiwi commented Jun 9, 2022

I apologize for the lack of updates. I'll update Ryu's README shortly. Our team has not had the resources to fully maintain Ryu, so FAUCET has moved to os-ken. We are currently looking for assistance to help support Ryu.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants