ensure that a client can only keep one passive listener open at a time #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
+ Coverage 86.25% 86.46% +0.20%
==========================================
Files 11 11
Lines 1601 1603 +2
==========================================
+ Hits 1381 1386 +5
+ Misses 152 151 -1
+ Partials 68 66 -2
☔ View full report in Codecov by Sentry. |
A client might send many PASV commands and never send a transfer command. This will lead to passive ports exhaustion.
|
Thank you for merging. I think there is also another issue, see here but I'm unable to replicate and the user hasn't provided enough logs to understand what is happening. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A client might send many PASV commands and never send a transfer command. This will lead to passive ports exhaustion.