This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
implement node-config #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kc-dot-io
force-pushed
the
node-config
branch
3 times, most recently
from
68bcfe6 to
879f067
Compare
kc-dot-io
force-pushed
the
node-config
branch
from
879f067 to
4960d00
Compare
|
Looks good to me. @slajax can you maybe add what the old signature used to be vs. the new signature (ie. better highlight the breaking changes). I think we can release this as v0.4. Anything below < 1.0 that has breaking changes is fine to be a minor release. Since @daffl wrote all of this he should be the one to give the ship. |
|
Ah right on, good point. Yeah I'll make it v0.4 and update the readme to better highlight the change log like I did in the issue body. Agreed @daffl should review. |
|
Looks great, thank you! I'll release it later today. We might want to update https://docs.feathersjs.com/configuration/readme.html as well. |
|
Released in v0.4.0 |
This was referenced Oct 23, 2016
Merged
kc-dot-io
added a commit
that referenced
this pull request
Oct 23, 2016
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overview
This is a mostly backwards compatible implementation of node-config.
It closes #25 and should be able to merge separately from #26 if we think we want to release it without all the other goodies described in that epic.
change log
NODE_CONFIG_DIRandNODE_ENVconfiguration()constructor directly to get the full config objectrelease
Since there is still a pretty major breaking API change within the constructor I think we should release this as 0.4 or 1.0 in Auk and then release #26 as next stable during Buzzard.