Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix/update dependencies infer paginate params #418

Merged
merged 4 commits into from
Jun 21, 2023

Conversation

fratzinger
Copy link
Contributor

Problem:

I use the [key: string]: any hack for Params, as suggested in the migration guide:

declare module "@feathersjs/feathers" {
  interface Params {
    [key: string]: any;
  }
}

see: https://feathersjs.com/guides/migrating.html#typed-params-and-query

When doing this, the find params can not be inferred correctly and the function overloads do not work. By using conditional types the ReturnResult is correct.

@fratzinger fratzinger merged commit 300644f into master Jun 21, 2023
@fratzinger fratzinger deleted the fix/update-dependencies-infer-paginate-params branch June 27, 2023 09:00
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant