This repository was archived by the owner on Mar 22, 2022. It is now read-only.
Allow the cookie to be set if action is not remove
#474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the service requirement for setting the cookie. If it did run after `remove` it won’t set the cookie, though.
ekryski
reviewed
Apr 7, 2017
| // we weren't removing the token and we have a JWT access token. | ||
| if (res.hook && res.hook.method !== 'remove' && res.data && res.data.accessToken) { | ||
| // Don't set the cookie if this was called after removing the token. | ||
| if (res.hook && res.hook.method === 'remove') { |
There was a problem hiding this comment.
Yup I think this should be fine. Good catch on that issue. Funny how simple logic can have such implications.
|
|
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the service requirement for setting the cookie. If it did run after
removeit won’t set the cookie, though.Closes feathersjs-ecosystem/authentication-oauth2#12