fix(configuration): Only validate the initial configuration against t…

…he schema (#2622)
feathersjs · May 4, 2022 · 386c5e2 · 386c5e2
1 parent 2bbb103
commit 386c5e2
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/packages/configuration/src/index.ts b/packages/configuration/src/index.ts
@@ -11,21 +11,24 @@ export = function init (schema?: Schema<any>) {
       return config;
     }
 
+
+    const configuration: { [key: string]: unknown } = { ...config };
+
     debug(`Initializing configuration for ${config.util.getEnv('NODE_ENV')} environment`);
 
-    Object.keys(config).forEach(name => {
-      const value = (config as any)[name];
+    Object.keys(configuration).forEach(name => {
+      const value = configuration[name];
       debug(`Setting ${name} configuration value to`, value);
       app.set(name, value);
     });
 
     if (schema) {
       app.hooks({
-        setup: [async (context: ApplicationHookContext, next: NextFunction) => {
-          await schema.validate(context.app.settings);
+        setup: [async (_context: ApplicationHookContext, next: NextFunction) => {
+          await schema.validate(configuration);
           await next();
         }]
-      })
+      });
     }
 
     return config;