fix(databases): Make sure adapter method signatures are exported prop…

…erly (#2943)
feathersjs · Dec 20, 2022 · 458d668 · 458d668
1 parent 9ea9e5d
commit 458d668
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/knex/src/index.ts b/packages/knex/src/index.ts
@@ -37,6 +37,7 @@ export class KnexService<
 
   async create(data: Data, params?: ServiceParams): Promise<Result>
   async create(data: Data[], params?: ServiceParams): Promise<Result[]>
+  async create(data: Data | Data[], params?: ServiceParams): Promise<Result | Result[]>
   async create(data: Data | Data[], params?: ServiceParams): Promise<Result | Result[]> {
     if (Array.isArray(data) && !this.allowsMulti('create', params)) {
       throw new MethodNotAllowed('Can not create multiple entries')
@@ -54,6 +55,7 @@ export class KnexService<
 
   async patch(id: Id, data: PatchData, params?: ServiceParams): Promise<Result>
   async patch(id: null, data: PatchData, params?: ServiceParams): Promise<Result[]>
+  async patch(id: NullableId, data: PatchData, params?: ServiceParams): Promise<Result | Result[]>
   async patch(id: NullableId, data: PatchData, params?: ServiceParams): Promise<Result | Result[]> {
     const { $limit, ...query } = await this.sanitizeQuery(params)
 
@@ -65,6 +67,7 @@ export class KnexService<
 
   async remove(id: Id, params?: ServiceParams): Promise<Result>
   async remove(id: null, params?: ServiceParams): Promise<Result[]>
+  async remove(id: NullableId, params?: ServiceParams): Promise<Result | Result[]>
   async remove(id: NullableId, params?: ServiceParams): Promise<Result | Result[]> {
     const { $limit, ...query } = await this.sanitizeQuery(params)
 

diff --git a/packages/mongodb/src/index.ts b/packages/mongodb/src/index.ts
@@ -32,6 +32,7 @@ export class MongoDBService<
 
   async create(data: Data, params?: ServiceParams): Promise<Result>
   async create(data: Data[], params?: ServiceParams): Promise<Result[]>
+  async create(data: Data | Data[], params?: ServiceParams): Promise<Result | Result[]>
   async create(data: Data | Data[], params?: ServiceParams): Promise<Result | Result[]> {
     if (Array.isArray(data) && !this.allowsMulti('create', params)) {
       throw new MethodNotAllowed('Can not create multiple entries')
@@ -49,6 +50,7 @@ export class MongoDBService<
 
   async patch(id: null, data: PatchData, params?: ServiceParams): Promise<Result[]>
   async patch(id: AdapterId, data: PatchData, params?: ServiceParams): Promise<Result>
+  async patch(id: NullableAdapterId, data: PatchData, params?: ServiceParams): Promise<Result | Result[]>
   async patch(id: NullableAdapterId, data: PatchData, params?: ServiceParams): Promise<Result | Result[]> {
     const { $limit, ...query } = await this.sanitizeQuery(params)
 
@@ -60,6 +62,7 @@ export class MongoDBService<
 
   async remove(id: AdapterId, params?: ServiceParams): Promise<Result>
   async remove(id: null, params?: ServiceParams): Promise<Result[]>
+  async remove(id: NullableAdapterId, params?: ServiceParams): Promise<Result | Result[]>
   async remove(id: NullableAdapterId, params?: ServiceParams): Promise<Result | Result[]> {
     const { $limit, ...query } = await this.sanitizeQuery(params)