fix(socketio-client): Make Socket.io client event target compatible (#…

…2686)
feathersjs · Jul 13, 2022 · 716c49a · 716c49a
1 parent 41b3761
commit 716c49a
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/socketio-client/test/index.test.ts b/packages/socketio-client/test/index.test.ts
@@ -88,6 +88,10 @@ describe('@feathersjs/socketio-client', () => {
     }
   })
 
+  it('is event target compatible', async () => {
+    app.service('todo').addEventListener('created', (data: any) => assert.ok(data))
+  })
+
   it('calls .customMethod', async () => {
     const service = app.service('todos')
     const result = await service.customMethod({ message: 'hi' })

diff --git a/packages/transport-commons/src/client.ts b/packages/transport-commons/src/client.ts
@@ -7,6 +7,7 @@ const debug = createDebug('@feathersjs/transport-commons/client')
 
 const namespacedEmitterMethods = [
   'addListener',
+  'addEventListener',
   'emit',
   'listenerCount',
   'listeners',
@@ -15,6 +16,7 @@ const namespacedEmitterMethods = [
   'prependListener',
   'prependOnceListener',
   'removeAllListeners',
+  'removeEventListener',
   'removeListener'
 ]
 const otherEmitterMethods = ['eventNames', 'getMaxListeners', 'setMaxListeners']