Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Regression in location/path name with latest refactor (for sockets) #119

Closed
marshallswain opened this issue Feb 27, 2015 · 2 comments
Closed

Comments

@marshallswain
Copy link
Member

We now have two service methods.
One here: https://github.com/feathersjs/feathers/blob/master/lib/application.js#L25
The other gets mixed in here: (or in primus.js): https://github.com/feathersjs/feathers/blob/master/lib/providers/socket/socketio.js#L16

stripSlashes() is only called in the first one. Since the second service method gets called directly from app.use(), is the proper fix to simply add a stripSlashes() here: https://github.com/feathersjs/feathers/blob/master/lib/application.js#L76

@daffl
Copy link
Member

daffl commented Mar 6, 2015

This should be fixed via feathersjs-ecosystem/commons@f05b950

@daffl daffl closed this as completed Mar 6, 2015
daffl pushed a commit that referenced this issue Aug 25, 2018
@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants