Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(databases): Make sure adapter method signatures are exported properly #2943

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

daffl
Copy link
Member

@daffl daffl commented Dec 20, 2022

This is a follow-up for #2918 to make sure that all override signatures documented in https://dove.feathersjs.com/guides/cli/service.class.html#service-customization are working (apparently you have to duplicate the most generic one over the actual implementation).

@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for feathers-dove canceled.

Name Link
🔨 Latest commit 1d83eaa
🔍 Latest deploy log https://app.netlify.com/sites/feathers-dove/deploys/63a149587b56d2000b39b1c0

@daffl daffl merged commit 458d668 into dove Dec 20, 2022
@daffl daffl deleted the database-signatures branch December 20, 2022 16:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant