[Question] app.configure without scope?

[cpsubrian]

Since I'm fairly new to using feathers, I was wondering the philosophy behind the pervasive use of scope in various parts of the API. I used to design APIs this way as well but lately have preferred more functional/explicit designs.

For example:

function myPlugin (options) {
  return function () {
    var app = this
  }
}
app.configure(myPlugin({}))

vs.

function myPlugin (options) {
  return function (app) {}
}
app.configure(myPlugin({}))

I understand that it would be a huge breaking change (and thus probably not realistic), but at least in this case it could be changed in a backwards compatible way (but other things like hooks and services are tricker).

[marshallswain]

There's a comment about this in the code: https://github.com/feathersjs/feathers/blob/master/src/application.js#L110

[daffl]

This was how Express used to do it. It wouldn't be a huge change to additionally pass the app as an argument.

[cpsubrian]

@daffl Indeed, and I could easily override with my own version that does this ... was more just curious if it was a core API design opinion.

[daffl]

This has been added in v3 (see linked PR)

[lock]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.