Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Uberproto objects don't need to be extended #57

Closed
daffl opened this issue Apr 23, 2014 · 2 comments
Closed

Uberproto objects don't need to be extended #57

daffl opened this issue Apr 23, 2014 · 2 comments

Comments

@daffl
Copy link
Member

daffl commented Apr 23, 2014

By default all services will be extended with Uberproto in https://github.com/feathersjs/feathers/blob/master/lib/application.js#L22. While this most likely works it isn't necessary if the object is already an instanceof Proto.
@daffl daffl modified the milestone: 1.0.0 Apr 26, 2014
@daffl
Copy link
Member Author

daffl commented Apr 26, 2014

Actually nevermind. We probably do always want to create a new object it might be weird to get behaviour mixed into your existing object.

@daffl daffl closed this as completed Apr 26, 2014
daffl added a commit that referenced this issue Aug 19, 2018
@daffl
Rename repository and add to npm scope (#57)
4810075 
* Rename repository and add to npm scope

* Remove circular Feathers dependency
daffl added a commit that referenced this issue Aug 21, 2018
@daffl
Rename repository and add to npm scope (#57)
086a6a9 
* Rename repository and add to npm scope

* Remove circular Feathers dependency
daffl pushed a commit that referenced this issue Aug 21, 2018
@greenkeeper @daffl
chore(package): update uws to version 8.14.0 (#57)
1cf3b5f
daffl pushed a commit that referenced this issue Aug 22, 2018
@greenkeeper @daffl
chore(package): update uws to version 8.14.0 (#57)
f9d2272
daffl pushed a commit that referenced this issue Aug 23, 2018
@chaintng @daffl
misspelling (#57)
95bae17 
misspelling
daffl pushed a commit that referenced this issue Aug 28, 2018
@greenkeeper @daffl
chore(package): update sinon-chai to version 3.0.0 (#57)
3d19a3c
daffl pushed a commit that referenced this issue Aug 28, 2018
@greenkeeper @daffl
chore(package): update sinon-chai to version 3.0.0 (#57)
5d4be53
daffl pushed a commit that referenced this issue Aug 29, 2018
@j2L4e @daffl
typings: add auth methods to feathers.Application interface (#57)
a1930d2
daffl pushed a commit that referenced this issue Aug 29, 2018
@greenkeeper @daffl
chore(package): update sinon-chai to version 3.0.0 (#57)
cbad7c9
daffl pushed a commit that referenced this issue Aug 29, 2018
@greenkeeper @daffl
chore(package): update sinon-chai to version 3.0.0 (#57)
e4cb878
daffl pushed a commit that referenced this issue Aug 29, 2018
@j2L4e @daffl
typings: add auth methods to feathers.Application interface (#57)
6ee05f8
@lock
Copy link

lock bot commented Feb 8, 2019

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue with a link to this issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daffl